fix: quarantine unavailable upstream routes and harden upgrades
This commit is contained in:
1 parent
9acc69d4c7
commit
59907cebdf
8 files changed
+424
-3
No files matched your search
@@ -0,0 +1,90 @@
|
||||
import importlib.util
|
||||
import json
|
||||
from pathlib import Path
|
||||
from types import SimpleNamespace
|
||||
import subprocess
|
||||
import tempfile
|
||||
import unittest
|
||||
from unittest.mock import Mock, patch
|
||||
|
||||
|
||||
DIRECTORY = Path(__file__).resolve().parents[1]
|
||||
SPEC = importlib.util.spec_from_file_location("upgrade_release", DIRECTORY / "upgrade_release.py")
|
||||
upgrade_release = importlib.util.module_from_spec(SPEC)
|
||||
SPEC.loader.exec_module(upgrade_release)
|
||||
|
||||
|
||||
def config(release, name="moyi-test"):
|
||||
return {
|
||||
"name": name,
|
||||
"services": {
|
||||
"moyi-api": {"image": "moyi-api:" + release, "build": {"dockerfile": "Dockerfile.runtime"}},
|
||||
"frontend": {"image": "moyi-frontend:" + release, "build": {"dockerfile": "Dockerfile.runtime"}},
|
||||
},
|
||||
}
|
||||
|
||||
|
||||
class UpgradeReleaseTests(unittest.TestCase):
|
||||
def test_child_detaches_stdin(self):
|
||||
completed = SimpleNamespace(returncode=0, stdout="output")
|
||||
with patch.object(upgrade_release.subprocess, "run", return_value=completed) as runner:
|
||||
self.assertEqual(upgrade_release.child(["docker", "info"], capture=True), "output")
|
||||
self.assertEqual(runner.call_args.kwargs["stdin"], subprocess.DEVNULL)
|
||||
|
||||
def test_environment_is_pinned_to_manifest_release_and_runtime_dockerfiles(self):
|
||||
with tempfile.TemporaryDirectory() as directory:
|
||||
root = Path(directory)
|
||||
old = root / "old" / "infra" / "moyi"
|
||||
new = root / "20260928-000000-test" / "infra" / "moyi"
|
||||
old.mkdir(parents=True)
|
||||
new.mkdir(parents=True)
|
||||
(old / ".env.cloud").write_text("MOYI_IMAGE_TAG=old\n", encoding="utf-8")
|
||||
(new / "deploy.py").write_text("# test\n", encoding="utf-8")
|
||||
(new / ".env.cloud").write_text("MOYI_IMAGE_TAG=old\n", encoding="utf-8")
|
||||
env = upgrade_release.update_release_environment(old, new, "20260928-000000-test")
|
||||
text = env.read_text(encoding="utf-8")
|
||||
self.assertIn("MOYI_IMAGE_TAG=20260928-000000-test", text)
|
||||
self.assertIn("MOYI_API_DOCKERFILE=Dockerfile.runtime", text)
|
||||
self.assertIn("MOYI_FRONTEND_DOCKERFILE=Dockerfile.runtime", text)
|
||||
|
||||
def test_upgrade_backs_up_before_starting_new_project_without_down(self):
|
||||
with tempfile.TemporaryDirectory() as directory:
|
||||
root = Path(directory)
|
||||
release = "20260928-000000-test"
|
||||
old = root / "old" / "infra" / "moyi"
|
||||
new = root / release / "infra" / "moyi"
|
||||
old.mkdir(parents=True)
|
||||
new.mkdir(parents=True)
|
||||
(old / ".env.cloud").write_text("MOYI_IMAGE_TAG=old\n", encoding="utf-8")
|
||||
(old / "deploy.py").write_text("# test\n", encoding="utf-8")
|
||||
(new / "deploy.py").write_text("# test\n", encoding="utf-8")
|
||||
(old / "certs").mkdir()
|
||||
(old / "certs" / "fullchain.pem").write_text("cert\n", encoding="utf-8")
|
||||
(old / "certs" / "privkey.pem").write_text("key\n", encoding="utf-8")
|
||||
(new.parent.parent / "release-manifest.json").write_text(json.dumps({"release": release}), encoding="utf-8")
|
||||
backup_dir = root / "backups" / "pre-upgrade"
|
||||
backup_dir.mkdir(parents=True)
|
||||
(backup_dir / "backup-complete.json").write_text("{}", encoding="utf-8")
|
||||
events = []
|
||||
old_deploy = SimpleNamespace(preflight=Mock(side_effect=lambda *args: config("old")))
|
||||
|
||||
class NewDeploy:
|
||||
def preflight(self, *args):
|
||||
return config(release)
|
||||
|
||||
def compose_command(self, env_file, mode):
|
||||
return ["docker", "compose"]
|
||||
|
||||
def execute(self, command, capture=False):
|
||||
events.append(command)
|
||||
|
||||
with patch.object(upgrade_release, "load_module", side_effect=[old_deploy, NewDeploy()]), \
|
||||
patch.object(upgrade_release, "backup_current", side_effect=lambda *args: (events.append(["backup"]), backup_dir)[1]):
|
||||
upgrade_release.upgrade(old, new, output_root=root / "backups", accept_migrations=True)
|
||||
self.assertEqual(events[0], ["backup"])
|
||||
self.assertTrue(events)
|
||||
self.assertFalse(any("down" in event for event in events if isinstance(event, list)))
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in new issue
Block a user